cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <>
Subject [jira] Commented: (CASSANDRA-699) Add (optional) expiration time for column
Date Fri, 02 Apr 2010 15:40:27 GMT


Sylvain Lebresne commented on CASSANDRA-699:

> We shouldn't mix client-provided timestamps (we cannot rely on them being a
> specific meaning) with server-side ones. so getMarkedForDeleteAt should just
> return localExpirationTime. 

I agree with you about not mixing. But I'm not fan of returning localExpirationTime
as for superColumn and columnFamily, the getMarkedForDeleteAt() returns a
client-provided timestamp. That's why initially I put it that way. 

But looking it right now, it seems that for columns (and thus ExpiringColumn),
the value of getMarkedForDeleteAt() is never actually used. Maybe we could
then return simply the timestamp (and add a comment!).

> Shouldn't we allow explicitly deleting an expiring column? 

What do you mean ? An expiring column could be deleted the usual way, or am I
missing something ?

> I think most of the deserialize code shouldn't need to be copy/pasted in both
> if blocks. 

I agree. Not sure why I didn't do it. To avoid to have to retest at the end if
we return a Column or an ExpiringColumn I guess. But that was more lazy of me
than anything else.

> Add (optional) expiration time for column 
> ------------------------------------------
>                 Key: CASSANDRA-699
>                 URL:
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 0.7
>         Attachments: 0001-Add-new-ExpiringColumn-class-v2.patch, 0002-Add-TTL-support-to-cassandra.thrift.patch,
0003-Plug-thrift-TTL-addition-to-ExpiringColumn.patch, 0004-Update-test_server-for-insert-changes-and-add-simple.patch,
add_expiring_column_0.6beta2.diff, modify_test_0.6beta2.diff, thrift_API_change_0.6beta2.diff
> Allow to attach an expiration time to a column. 
> An expired column would act much like a 'markedForDelete' one. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message