cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <>
Subject [jira] [Updated] (CASSANDRA-2324) Repair transfers more data than necessary
Date Fri, 08 Apr 2011 01:31:06 GMT


Sylvain Lebresne updated CASSANDRA-2324:

    Attachment: 0001-Make-repair-operate-over-a-node-token-range-v2.patch

bq. SSTableBoundScanner might be much simpler if it iterates within a list of file offsets,
as returned by SSTableReader.getPositionsForRanges

Good call, that's much simpler. Thanks.

bq. SSTableReader.getKeySamples could perform two binary searches for min and max rather than
doing sequential comparisons to the keys

Yeah, realized getKeySamples was buggy anyway since it wasn't handling wrapping ranges correctly.

Attaching patch that simplify the bounded scanner and fixes getKeySamples.

> Repair transfers more data than necessary
> -----------------------------------------
>                 Key: CASSANDRA-2324
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Brandon Williams
>            Assignee: Sylvain Lebresne
>             Fix For: 0.8
>         Attachments: 0001-Make-repair-operate-over-a-node-token-range-v2.patch, 0001-Make-repair-operate-over-a-node-token-range.patch
> To repro: 3 node cluster, 1M rows with -x KEYS and -l 2.  The index is enough
to make some mutations drop (about 20-30k total in my tests).  Repair afterwards will repair
a large amount of ranges the first time.  However, each subsequent run will repair the same
set of small ranges every time.  INDEXED_RANGE_SLICE in stress never fully works.  Counting
rows with sstablekeys shows there are 2M rows total as expected, however when trying to count
the indexed keys, I get exceptions like:
> {noformat}
> Exception in thread "main" Key out of order! DecoratedKey(101571366040797913119296586470838356016,
> DecoratedKey(12639574763031545147067490818595764132, 0bc414be3093348a2ad389ed28f18f0cc9a044b2e98587848a0d289dae13ed0ad479c74654900eeffc6236)
>         at
>         at
> {noformat}

This message is automatically generated by JIRA.
For more information on JIRA, see:

View raw message