cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stu Hood (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-2641) AbstractBounds.normalize should deal with overlapping ranges
Date Thu, 12 May 2011 23:42:47 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Stu Hood updated CASSANDRA-2641:
--------------------------------

    Attachment: 0002-Don-t-use-overlapping-ranges-in-tests.txt
                0001-Assert-non-overlapping-ranges-in-normalize.txt

I ended up leaving the assertion in place: making normalize support overlapping ranges is
handy, but it is more complicated than we truly need, and I'd rather not open that can of
worms until it's a requirement.

0002 fixes the streaming tests to use non-overlapping ranges.

> AbstractBounds.normalize should deal with overlapping ranges
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-2641
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2641
>             Project: Cassandra
>          Issue Type: Test
>          Components: Core
>            Reporter: Stu Hood
>            Assignee: Stu Hood
>            Priority: Minor
>             Fix For: 1.0
>
>         Attachments: 0001-Assert-non-overlapping-ranges-in-normalize.txt, 0002-Don-t-use-overlapping-ranges-in-tests.txt,
normalize-assert.diff
>
>
> Apparently no consumers have encountered it in production, but AbstractBounds.normalize
does not handle overlapping ranges. If given overlapping ranges, the output will be sorted
but still overlapping, for which SSTableReader.getPositionsForRanges will choose ranges in
an SSTable that may overlap.
> We should either add an assert in normalize(), or in getPositionsForRanges() to ensure
that this never bites us in production.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message