cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Stepura (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-6381) Refactor nodetool
Date Wed, 08 Jan 2014 19:24:55 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865771#comment-13865771
] 

Mikhail Stepura commented on CASSANDRA-6381:
--------------------------------------------

h5. REBUILD_INDEX
bq. The old behavior (csv format) was not really POSIX-like argument conventions. 
Your description for REBUILD_INDEX still describes CSV format: {{(IndexNameExample: Standard3.IdxName,Standard3.IdxName1)}}.
So there is a disconnect between the behavior and its description/documentation.


h5. SETCOMPACTIONTHRESHOLD:
{quote}It was not possible before, see the condition in NodeCmd.
{code}
if (minthreshold < 2 && maxthreshold != 0)    { badUse("Min threshold must be at
least 2"); }
{code}
{quote}
It was. Remember, {{maxthreshold == 0}} so the condition is false

h5. STATUS
Why assign to null initially?
{code:java|title=getOwnershipByDc}
                        String dc = null;
                        dc = epSnitchInfo.getDatacenter(ownership.ip);
{code}

h5. TRUNCATEHINTS
You only have 1 parameter there. Why do you use a list to hold it?

> Refactor nodetool
> -----------------
>
>                 Key: CASSANDRA-6381
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6381
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Yuki Morishita
>            Assignee: Clément Lardeur
>            Priority: Minor
>              Labels: lhf, nodetool
>         Attachments: trunk-6381-v2.patch, trunk-6381.patch
>
>
> We have way too many nodetool commands(more than 40) packed in one NodeCmd class. And
we are trying to add more commands.
> https://github.com/airlift/airline could be a good fit to take out each command into
sub command class.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message