cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Stepura (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-6381) Refactor nodetool
Date Wed, 08 Jan 2014 19:24:55 GMT


Mikhail Stepura commented on CASSANDRA-6381:

bq. The old behavior (csv format) was not really POSIX-like argument conventions. 
Your description for REBUILD_INDEX still describes CSV format: {{(IndexNameExample: Standard3.IdxName,Standard3.IdxName1)}}.
So there is a disconnect between the behavior and its description/documentation.

{quote}It was not possible before, see the condition in NodeCmd.
if (minthreshold < 2 && maxthreshold != 0)    { badUse("Min threshold must be at
least 2"); }
It was. Remember, {{maxthreshold == 0}} so the condition is false

Why assign to null initially?
                        String dc = null;
                        dc = epSnitchInfo.getDatacenter(ownership.ip);

You only have 1 parameter there. Why do you use a list to hold it?

> Refactor nodetool
> -----------------
>                 Key: CASSANDRA-6381
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Yuki Morishita
>            Assignee: Clément Lardeur
>            Priority: Minor
>              Labels: lhf, nodetool
>         Attachments: trunk-6381-v2.patch, trunk-6381.patch
> We have way too many nodetool commands(more than 40) packed in one NodeCmd class. And
we are trying to add more commands.
> could be a good fit to take out each command into
sub command class.

This message was sent by Atlassian JIRA

View raw message