cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulo Motta (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-10446) Run repair with down replicas
Date Fri, 02 Dec 2016 22:26:58 GMT


Paulo Motta commented on CASSANDRA-10446:

Sorry for the delay Blake, got sucked into other things... will try to be reply more promptly
on the next round.

skipping anti-compaction on the coordinator is not sufficient, since anti-compaction is what
cleans repair state on the replicas, a simpler approach here is to set the parent repair session
as {{!isGlobal}} when the force flag is set and this will already skip anti-compaction and
set {{repairedAt}} as {{ActiveRepairService.UNREPAIRED_SSTABLE}}.  By not needing to set the
{{repairedAt}} dynamically per-repair session, we can probably simplify this a bit and move
the force flag enforcement from {{RepairSession}}'s constructor to the alive check on  {{RepairSession.start}}.
What do you think?

If you agree with the suggestions, after you submit a new patch, could you please rebase,
prepare for commit and resubmit tests? Thanks!

> Run repair with down replicas
> -----------------------------
>                 Key: CASSANDRA-10446
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: sankalp kohli
>            Assignee: Blake Eggleston
>            Priority: Minor
>             Fix For: 4.0
> We should have an option of running repair when replicas are down. We can call it -force.

This message was sent by Atlassian JIRA

View raw message