cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dikang Gu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-12990) More fixes to the TokenAllocator
Date Thu, 22 Dec 2016 23:47:58 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-12990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15771412#comment-15771412
] 

Dikang Gu commented on CASSANDRA-12990:
---------------------------------------

[~blambov] thanks for the review! 

the [getRack | https://github.com/DikangGu/cassandra/commit/d986e89b7b21b5464bd1de7908ee5cb1d12dfd30#diff-bf046c281d96767f4c3c4fe97eeaf938R220]
was not what I meant to, I think it comes from some rebase error. I was meant to have each
node in separate group, as I put in the comment.

I've addressed other comments, please take a look again, thanks!

|[patch|https://github.com/DikangGu/cassandra/commit/76532058c950a53ef8e92e562556e2d59745fde8]|[unit
test|https://cassci.datastax.com/view/Dev/view/DikangGu/job/DikangGu-CASSANDRA-12990-trunk-testall/]|[dtest|https://cassci.datastax.com/view/Dev/view/DikangGu/job/DikangGu-CASSANDRA-12990-trunk-dtest/]|

> More fixes to the TokenAllocator
> --------------------------------
>
>                 Key: CASSANDRA-12990
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12990
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Dikang Gu
>            Assignee: Dikang Gu
>             Fix For: 3.12
>
>
> CASSANDRA-12983 fixes the NoReplicationTokenAllocator in the replication factor equals
0 case.
> We find one more problem that, in our big cluster, ~1000 nodes, the Gossip takes longer
time to settle down, so the TokenAllocator may throw NPE when trying to find the dc rack information
from the Gossip metadata, in the getStrategy function.
> This patch will fix it, it does two things:
> 1. wait gossip to settle down before trying to allocating tokens.
> 2. for replication factor equals 0 or 1 case, we do not need to check the topology for
rack information, since each node will be treated separately. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message