cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-11634) Add write timestamp to trace
Date Tue, 03 Jan 2017 17:51:58 GMT


Aleksey Yeschenko commented on CASSANDRA-11634:

My primary issue is having a tracing call in what should be a side-effect free, idempotent

The right spot for the trace call should be higher up in the call hierarchy, closer to modification
statements' {{execute}} methods. Maybe {{ModificationStatement.addUpdates()}}.

This would require the origin of the timestamp to be hoisted in higher level parameters object,
among other changes.

Unfortunately I don't myself have time to write a patch for this myself; but putting tracing
call in a getter is not right.

> Add write timestamp to trace
> ----------------------------
>                 Key: CASSANDRA-11634
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Observability
>            Reporter: Christopher Batey
>            Assignee: Christopher Batey
>            Priority: Minor
>             Fix For: 3.x
>         Attachments: 0001-Add-trace-message-for-write-timestamp.patch
> Diagnosing issues with clock drift would be easier if trace had the mutation timestamp.
I'll add a patch for this soon.
> Patch attached or at:

This message was sent by Atlassian JIRA

View raw message