cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Blake Eggleston (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-12982) Customizable hint ttl has been removed
Date Tue, 03 Jan 2017 19:43:58 GMT


Blake Eggleston commented on CASSANDRA-12982:

bq. Re-encoding the vint here isn't really an issue, so no real need to avoid it.

The name and usage of the method implies that it’s just reading some bytes out of an input,
with some additional logic to bail out early if the encoded hint is dead. To me, the method
actually recomputing some of the bytes it's returning seems very wrong. Someone reading HintsReader
wouldn’t expect the method to behave that way, and there doesn’t seem to be any benefit
to doing it that way. It’s slightly riskier, no faster, and approximately as understandable
as just copying the bytes.

I'm not a big fan, conceptually, of a conditional method with a name like deserializeIfLive
taking a force argument that basically turns it into an unconditional deserializer (and making
two or the arguments useless).

I much rather prefer some minor duplication to increased complexity but DRY-ness.

That’s reasonable, I’ve pushed up a commit changing that.

bq. If you don't mind strongly, I'd like to give it another go once back from vacation/bank
holidays - to make it a bit simpler and conceptually right, also ideally in a way that would
avoid having to pass size to deserializeIfLive.

Sure, go for it. I’d also prefer not passing size to deserializeIfLive, but didn’t see
a straightforward way of making that work.

> Customizable hint ttl has been removed
> --------------------------------------
>                 Key: CASSANDRA-12982
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>            Priority: Minor
>             Fix For: 3.x
> The cassandra.maxHintTTL property added in CASSANDRA-5988 was removed in the hint system
rewrite for 3.0.

This message was sent by Atlassian JIRA

View raw message