cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Corentin Chary (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13090) Coalescing strategy sleep too much
Date Mon, 09 Jan 2017 16:19:58 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15812149#comment-15812149
] 

Corentin Chary commented on CASSANDRA-13090:
--------------------------------------------

otc_coalescing_max_coalesced_messages was introduced because it could give more priority to
the reader due to the way drainTo() is implemented (lock, iterate, unlock). But since the
backlog is currently unbounded and all this code generally burst into flames under sustain
load if backlog.size() > 100Mk, I agree that this may not be necessary for now. *Removed*

I think I also fixed the typo I found.

I harmonized movingaverage and timehorizon strategies to have a coalesceInternal() that look
similar.

> Coalescing strategy sleep too much
> ----------------------------------
>
>                 Key: CASSANDRA-13090
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13090
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Streaming and Messaging
>            Reporter: Corentin Chary
>             Fix For: 3.x
>
>         Attachments: 0001-Fix-wait-time-coalescing-CASSANDRA-13090-2.patch, 0001-Fix-wait-time-coalescing-CASSANDRA-13090.patch
>
>
> With the current code maybeSleep is called even if we managed to take maxItems out of
the backlog. In this case we should really avoid sleeping because it means that backlog is
building up.
> I'll send a patch shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message