cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ariel Weisberg (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13373) Provide additional speculative retry statistics
Date Wed, 29 Mar 2017 21:01:41 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15947876#comment-15947876
] 

Ariel Weisberg commented on CASSANDRA-13373:
--------------------------------------------

OK ready for review again. I changed things up quite a bit renaming the metrics and adding
more. I also added a unit test. I don't really like overriding methods in ReadCallback since
it's not really intended to be an extension point so I went with catching and rethrowing the
exception.

> Provide additional speculative retry statistics
> -----------------------------------------------
>
>                 Key: CASSANDRA-13373
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13373
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Observability
>            Reporter: Ariel Weisberg
>            Assignee: Ariel Weisberg
>             Fix For: 4.x
>
>
> Right now there is a single metric for speculative retry on reads that is the number
of speculative retries attempted. You can't tell how many of those actually succeeded in salvaging
the read.
> The metric is also per table and there is no keyspace level rollup as there is for several
other metrics.
> Add a metric that counts reads that attempt to speculate but fail to complete before
the timeout (ignoring read errors).
> Add a rollup metric for the current count of speculation attempts as well as the count
of failed speculations.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message