cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jordan West (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-14442) Let nodetool import take a list of directories
Date Fri, 01 Jun 2018 17:15:00 GMT


Jordan West commented on CASSANDRA-14442:

LGTM. I'm +1 as is but one minor suggestion if you feel like including it:

The live SSTable check could be replaced by the following. Its a little more succinct and
less work (since we do the "contains" check in the iteration instead of afterwards):
boolean isLive = cfs.getLiveSSTables().stream().filter(r -> r.descriptor.equals(newDescriptor)
|| r.descriptor.equals(oldDescriptor)).findAny().isPresent();
if (isLive) 
    String message = String.format("Can't move and open a file that is already in use in the
table %s -> %s", oldDescriptor, newDescriptor);
    throw new RuntimeException(message);

> Let nodetool import take a list of directories
> ----------------------------------------------
>                 Key: CASSANDRA-14442
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Major
>             Fix For: 4.x
> It should be possible to load sstables from several input directories when running nodetool
import. Directories that failed to import should be output.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message