cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jordan West (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14442) Let nodetool import take a list of directories
Date Fri, 01 Jun 2018 17:15:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498265#comment-16498265
] 

Jordan West commented on CASSANDRA-14442:
-----------------------------------------

LGTM. I'm +1 as is but one minor suggestion if you feel like including it:

The live SSTable check could be replaced by the following. Its a little more succinct and
less work (since we do the "contains" check in the iteration instead of afterwards):
{code:java}
boolean isLive = cfs.getLiveSSTables().stream().filter(r -> r.descriptor.equals(newDescriptor)
|| r.descriptor.equals(oldDescriptor)).findAny().isPresent();
if (isLive) 
{
    String message = String.format("Can't move and open a file that is already in use in the
table %s -> %s", oldDescriptor, newDescriptor);
    logger.error(message);
    throw new RuntimeException(message);
}
{code}
 

> Let nodetool import take a list of directories
> ----------------------------------------------
>
>                 Key: CASSANDRA-14442
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14442
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Major
>             Fix For: 4.x
>
>
> It should be possible to load sstables from several input directories when running nodetool
import. Directories that failed to import should be output.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message