cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Brown (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14451) Infinity ms Commit Log Sync
Date Tue, 05 Jun 2018 12:36:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501696#comment-16501696
] 

Jason Brown commented on CASSANDRA-14451:
-----------------------------------------

bq. Are the ArchiveCommitLog dtest failures expected on the 3.0 branch? 

Yes, 3.0 dtests consistently have about 14 failures, including {{ArchiveCommitLog}}. So, unfortunately,
this is expected.

bq. The “sleep any time we have left” comment would be more appropriate above the assignment
of wakeUpAt.

I left it where it was previously located, but can move it to the more logical spot.

bq. change in behavior of updating totalSyncDuration is intentional

lol, it wasn't intentional, but it now does the correct thing! You are right that in CASSANDRA-14108
I was adding time to mark the headers (without flushing) to {{totalSyncDuration}}, which is
incorrect.

bq. Is there are reason you opted for the “excessTimeToFlush” approach in 3.0 but the
“maxFlushTimestamp” approach on 3.11 and trunk?

I wanted to keep the logic as close to the original as possible, since 3.0 is far along in
it's age. I suppose it doesn't matter that much, though, and can change if you think it's
worthwhile. wdyt?

> Infinity ms Commit Log Sync
> ---------------------------
>
>                 Key: CASSANDRA-14451
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14451
>             Project: Cassandra
>          Issue Type: Bug
>         Environment: 3.11.2 - 2 DC
>            Reporter: Harry Hough
>            Assignee: Jason Brown
>            Priority: Minor
>             Fix For: 3.0.x, 3.11.x, 4.0.x
>
>
> Its giving commit log sync warnings where there were apparently zero syncs and therefore
gives "Infinityms" as the average duration
> {code:java}
> WARN [PERIODIC-COMMIT-LOG-SYNCER] 2018-05-16 21:11:14,294 NoSpamLogger.java:94 - Out
of 0 commit log syncs over the past 0.00s with average duration of Infinityms, 1 have exceeded
the configured commit interval by an average of 74.40ms 
> WARN [PERIODIC-COMMIT-LOG-SYNCER] 2018-05-16 21:16:57,844 NoSpamLogger.java:94 - Out
of 0 commit log syncs over the past 0.00s with average duration of Infinityms, 1 have exceeded
the configured commit interval by an average of 198.69ms 
> WARN [PERIODIC-COMMIT-LOG-SYNCER] 2018-05-16 21:24:46,325 NoSpamLogger.java:94 - Out
of 0 commit log syncs over the past 0.00s with average duration of Infinityms, 1 have exceeded
the configured commit interval by an average of 264.11ms 
> WARN [PERIODIC-COMMIT-LOG-SYNCER] 2018-05-16 21:29:46,393 NoSpamLogger.java:94 - Out
of 32 commit log syncs over the past 268.84s with, average duration of 17.56ms, 1 have exceeded
the configured commit interval by an average of 173.66ms{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message