cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14436) Add sampler for query time and expose with nodetool
Date Sat, 04 Aug 2018 02:44:01 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569009#comment-16569009
] 

ASF GitHub Bot commented on CASSANDRA-14436:
--------------------------------------------

Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/244#discussion_r207697707
  
    --- Diff: src/java/org/apache/cassandra/metrics/Sampler.java ---
    @@ -0,0 +1,67 @@
    +package org.apache.cassandra.metrics;
    +
    +import java.io.Serializable;
    +import java.util.List;
    +import java.util.concurrent.LinkedBlockingQueue;
    +import java.util.concurrent.ThreadPoolExecutor;
    +import java.util.concurrent.TimeUnit;
    +
    +import org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor;
    +import org.apache.cassandra.concurrent.NamedThreadFactory;
    +
    +import com.google.common.annotations.VisibleForTesting;
    +
    +public abstract class Sampler<T>
    --- End diff --
    
    It would be nice to have a jmh benchmark for the new `Sampler`s


> Add sampler for query time and expose with nodetool
> ---------------------------------------------------
>
>                 Key: CASSANDRA-14436
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14436
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Chris Lohfink
>            Assignee: Chris Lohfink
>            Priority: Major
>
> Create a new {{nodetool profileload}} that functions just like toppartitions but with
more data, returning the slowest local reads and writes on the host during a given duration
and highest frequency touched partitions (same as {{nodetool toppartitions}}). Refactor included
to extend use of the sampler for uses outside of top frequency (max instead of total sample
values).
> Future work to this is to include top cpu and allocations by query and possibly tasks/cpu/allocations
by stage during time window.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message