cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Per Otterström (JIRA) <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14772) Refactor audit / full query log
Date Fri, 21 Sep 2018 13:24:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623614#comment-16623614
] 

Per Otterström commented on CASSANDRA-14772:
--------------------------------------------

bq. add a new tool to dump audit logs (ie, let fqltool be full query log specific)

ATM fqltool isn't compatible with BinLog audit logs:
{noformat}
$ ./tools/bin/fqltool dump ~/.ccm/trunk/node1/audit/
error: null
-- StackTrace --
java.lang.NullPointerException
	at io.netty.buffer.Unpooled.wrappedBuffer(Unpooled.java:155)
	at org.apache.cassandra.fqltool.commands.Dump.lambda$dump$0(Dump.java:96)
	at net.openhft.chronicle.queue.impl.single.SingleChronicleQueueExcerpts$StoreTailer.readDocument(SingleChronicleQueueExcerpts.java:1099)
	at org.apache.cassandra.fqltool.commands.Dump.dump(Dump.java:137)
	at org.apache.cassandra.fqltool.commands.Dump.run(Dump.java:66)
	at org.apache.cassandra.fqltool.FullQueryLogTool.main(FullQueryLogTool.java:65)
{noformat}

Seem to be broken since CASSANDRA-14675.

Not sure if I should create a separate ticket for this, or if we resolve it within the scope
of this ticket.


> Refactor audit / full query log
> -------------------------------
>
>                 Key: CASSANDRA-14772
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14772
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Major
>             Fix For: 4.0
>
>
> I find the audit + full query log code quite hard to follow with some of the naming and
mixing of concepts, this ticket aims to:
> * move full query log specific code to a separate package 
> * do some audit log class renames (I keep reading {{BinLogAuditLogger}} vs {{BinAuditLogger}}
wrong for example)
> * avoid parsing the CQL queries twice in {{QueryMessage}} when audit log is enabled.
> * add a new tool to dump audit logs (ie, let fqltool be full query log specific)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message