cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sam Tunnicliffe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14803) Rows that cross index block boundaries can cause incomplete reverse reads in some cases.
Date Thu, 04 Oct 2018 16:32:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638475#comment-16638475
] 

Sam Tunnicliffe commented on CASSANDRA-14803:
---------------------------------------------

The fix and test itself LGTM, but I don't quite see what's differentiates this test from the
others in {{LegacySSTableTest}}. What am I missing?

Also, it merges to 3.11 cleanly, but the test won't compile because {{DatabaseDescriptor::setDaemonInitialized}}
has been replaced there.

> Rows that cross index block boundaries can cause incomplete reverse reads in some cases.
> ----------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-14803
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14803
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>            Priority: Major
>             Fix For: 3.0.x, 3.11.x
>
>
> When we're reading 2.1 sstables in reverse, we skip the first row of an index block if
it's split across index boundaries. The entire row will be read at the end of the next block.
In some cases though, the only thing in this index block is the partial row, so we return
an empty iterator. The empty iterator is then interpreted as the end of the row further down
the call stack, so we return early without reading the rest of the data. This only affects
3.x during upgrades from 2.1



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message