cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Eriksson (Jira)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14496) TWCS erroneously disabling tombstone compactions when unchecked_tombstone_compaction=true
Date Fri, 02 Jul 2021 06:52:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17373264#comment-17373264
] 

Marcus Eriksson commented on CASSANDRA-14496:
---------------------------------------------

Shouldn't we enable tombstone compactions if any of those 3 options is explicitly set? Now
we would force a user to use {{UNCHECKED_TOMBSTONE_COMPACTION_OPTION}} if they want to enable
tombstone compactions at all for TWCS.

> TWCS erroneously disabling tombstone compactions when unchecked_tombstone_compaction=true
> -----------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-14496
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14496
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/Compaction
>            Reporter: Robert Tarrall
>            Assignee: Alexander Ivakov
>            Priority: Low
>             Fix For: 3.11.x, 4.0.x, 4.x
>
>
> This code:
> {code:java}
> this.options = new TimeWindowCompactionStrategyOptions(options);
> if (!options.containsKey(AbstractCompactionStrategy.TOMBSTONE_COMPACTION_INTERVAL_OPTION)
&& !options.containsKey(AbstractCompactionStrategy.TOMBSTONE_THRESHOLD_OPTION))
> {
> disableTombstoneCompactions = true;
> logger.debug("Disabling tombstone compactions for TWCS");
> }
> else
> logger.debug("Enabling tombstone compactions for TWCS");
> }
> {code}
> ... in TimeWindowCompactionStrategy.java disables tombstone compactions in TWCS if you
have not *explicitly* set either tombstone_compaction_interval or tombstone_threshold. 
Adding 'tombstone_compaction_interval': '86400' to the compaction stanza in a table definition
has the (to me unexpected) side effect of enabling tombstone compactions. 
> This is surprising and does not appear to be mentioned in the docs.
> I would suggest that tombstone compactions should be run unless these options are both
set to 0.
> If the concern is that (as with DTCS in CASSANDRA-9234) we don't want to waste time on
tombstone compactions when we expect the tables to eventually be expired away, perhaps we
should also check unchecked_tombstone_compaction and still enable tombstone compactions if
that's set to true.
> May also make sense to set defaults for interval & threshold to 0 & disable
if they're nonzero so that setting non-default values, rather than setting ANY value, is what
determines whether tombstone compactions are enabled?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message