cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksei Zotov (Jira)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-15438) MerkleTrees viriables renaming tree -> trees
Date Sun, 11 Jul 2021 17:20:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-15438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378708#comment-17378708
] 

Aleksei Zotov commented on CASSANDRA-15438:
-------------------------------------------

Hi [~xiangwang]!

Thanks for the interest to the project! I checked the patch and I totally support the idea
of renaming. However, the project has a consensus to not touch the code unless it is a part
of smth that inevitably requires a change (feature development, bug fixing, etc). In other
words, it is pretty hard to get such a refactoring approved and merged.

Even though it might sound weird and counter productive, there is a clear reason and background
for that. Currently the project maintains branches for multiple versions. Some branches take
fixes only while others new features and fixes. Obviously there are significant differences
between old and new branches and sometimes it is extremely hard to propagate certain changes
to old branches. Such refactoring changes increase the difference between branches which consequently
increases merging complexity even more. That's why the project took the approach to make refactoring
during feature development (like "if you touch some code, please, make it clean and clear;
otherwise don't touch it").

Another reason why such changes are unlikely to get merged is a shortage of committers time
- it is hard to get their attention to "zero business value" changes (despite they are still
useful from technical perspective). I think you can see yourself that no-one paid attention
to this ticket for more that 2 years.

With that being said, I believe it makes sense to get this ticket closed without anything
being merged. Alternative way would be to prepare a bunch of patches for multiple existing
branches and try to convince the community to pick them up, however, I doubt it will work
out unless you have an enormous aspiration.

[~blerer] your input would be highly appreciated.

PS:

I'm not a project committer, I'm just an enthusiast like you who is hanging around the project.
Some time ago I struggled with the same problem of being unable to merge my neat changes.
However, after a few cycles of propagating changes to old branches I realized why the community
took the path of minimizing "unnecessary" changes.

I hope I was not rude and discouraging. It is always great to see people who are ready to
dedicate their time to opensource projects. If you still have time and desire to contribute
something, please, check this page: [https://cassandra.apache.org/doc/latest/development/patches.html#choosing-what-to-work-on].
And feel free to ping me on Jira or Slack for support.

 

> MerkleTrees viriables renaming tree -> trees
> --------------------------------------------
>
>                 Key: CASSANDRA-15438
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15438
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: xiangwang
>            Assignee: xiangwang
>            Priority: Normal
>         Attachments: 0001-Rename-MerkleTrees-tree-to-MerkleTrees-trees.patch
>
>
> It's confusing that the virable tree is sometimes MerkleTrees instead of MerkleTree.
> I'd like to rename "MerkleTrees tree" to "MerkleTrees trees" to make the code easier
to read.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message