cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andres de la Peña (Jira) <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-15663) DESCRIBE KEYSPACE does not properly quote table names
Date Tue, 06 Jul 2021 11:36:01 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-15663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375610#comment-17375610
] 

Andres de la Peña commented on CASSANDRA-15663:
-----------------------------------------------

[~Gerrrr] you are totally right, the solution in CASSANDRA-16659 is not enough since pylib
indirectly depends on {{cql_keywords_reserved}} on multiple places. I think we should probably
have a followup ticket on 4.0/4.x for either reverting that approach and go back to using
the driver keywords, or completing the fix it by removing the remaining dependencies. CC [~e.dimitrova]

As for this ticket, I agree that upgrading and patching the driver is the way to go. However,
it seems that something is missed in the upgraded driver since it's not finding the dependency
on both [CircleCI|https://app.circleci.com/pipelines/github/adelapena/cassandra/635/workflows/762f47f2-0419-4e06-a342-d5258f1bbf16]
and [Jenkins|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/892/tests/].

> DESCRIBE KEYSPACE does not properly quote table names
> -----------------------------------------------------
>
>                 Key: CASSANDRA-15663
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15663
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CQL/Syntax
>            Reporter: Oskar Liljeblad
>            Assignee: Aleksandr Sorokoumov
>            Priority: Normal
>              Labels: pull-request-available
>             Fix For: 3.11.x
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> How to reproduce (3.11.6) - cqlsh:
> {code}
> CREATE KEYSPACE test1 WITH replication = \{'class': 'SimpleStrategy', 'replication_factor':
'1'} AND durable_writes = true;
> CREATE TABLE test1."default" (id text PRIMARY KEY, data text, etag text);
> DESCRIBE KEYSPACE test1;
> {code}
> Output will be:
> {code}
> CREATE TABLE test1.default (
>  id text PRIMARY KEY,
>  data text,
>  etag text
> ) WITH [..]
> {code}
> Output should be:
> {code}
> CREATE TABLE test1."default" (
>  id text PRIMARY KEY,
>  data text,
>  etag text
> ) WITH [..]
> {code}
>  If you try to run {{CREATE TABLE test1.default [..]}} you will get an error 
> SyntaxException: line 1:19 no viable alternative at input 'default' (CREATE TABLE test1.[default]...)
> Oskar Liljeblad
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message