cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andres de la Peña (Jira) <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
Date Wed, 14 Jul 2021 15:55:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380702#comment-17380702
] 

Andres de la Peña commented on CASSANDRA-16621:
-----------------------------------------------

This doesn't change that we still have to decide whether to use {{spinAssertEquals}} or {{Awaitility}},
but it's nice to use the same implementation for both methods. I guess that the criteria would
be using {{spinAssertEquals}} when possible, and reserve the direct call to {{Awaitility}}
for those cases in which more flexibility is required?

Regarding the poll interval, even though 1ms is probably the most similar thing to the original
implementation, I wonder whether it would be too low. Perhaps we could use Awaitility's default
interval of 100ms and then add an optimistic poll delay of zero?

> Replace spinAsserts code with Awaitility code
> ---------------------------------------------
>
>                 Key: CASSANDRA-16621
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16621
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: Berenguer Blasi
>            Assignee: Jogesh Anand
>            Priority: Normal
>              Labels: low-hanging-fruit
>             Fix For: 4.0.x
>
>
> Currently spinAsserts does a similar thing to Awaitility which is being used more and
more. We have now 2 ways of doing the same thing so it would be good to consolidate



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message