cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andres de la Peña (Jira) <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
Date Mon, 19 Jul 2021 16:26:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383435#comment-17383435
] 

Andres de la Peña commented on CASSANDRA-16621:
-----------------------------------------------

Here are some additional runs with LOWRES and HIGHRES:

||branch||resources||CI||
|4.0|LOW|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/674/workflows/b35679ab-ea54-42e5-bbca-fa2c12a290d7]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/674/workflows/57707052-cfc2-47b7-875f-520801f44bb2]|
|4.0|HIGH|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/676/workflows/5214df3b-75dc-4893-a41d-4ff2fe7a36ab]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/676/workflows/f44f558d-65e9-46ed-a697-31af338d5018]|
|trunk|LOW|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/675/workflows/d4fa9c8a-f3e4-46f3-ba33-cc4484b3b20a]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/675/workflows/9fef38c1-4727-4eff-ada6-8b782609daa5]|
|trunk|HIGH|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/677/workflows/5a411db9-3567-42ed-9a09-3dd1e299a27d]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/677/workflows/649833f3-7226-4103-b96f-dcbe7ff16d5a]|

I have added some multiplexed runs {{ViewFilteringTest}} because it's one the tests failing
with the {{ProtocolError}}/{{AlreadyExistsException}} errors, although I'm not finding them
anymore.

What seems to be consistently failing due to the changes is {{ThreadPoolMetricsTest}}. The
failure seems to be caused by the increased poll interval. We could reduce it again, but it
might be better to directly use {{Awaitility}} in {{ThreadPoolMetricsTest.spinAssertEquals}}
with a lower interval or, even better, try to use a better concurrency control in the test.

> Replace spinAsserts code with Awaitility code
> ---------------------------------------------
>
>                 Key: CASSANDRA-16621
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16621
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: Berenguer Blasi
>            Assignee: Jogesh Anand
>            Priority: Normal
>              Labels: low-hanging-fruit
>             Fix For: 4.0.x
>
>
> Currently spinAsserts does a similar thing to Awaitility which is being used more and
more. We have now 2 ways of doing the same thing so it would be good to consolidate



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message