cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andres de la Peña (Jira) <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-16817) Fix ERROR message which prints data information in the logs
Date Wed, 28 Jul 2021 12:38:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-16817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388734#comment-17388734
] 

Andres de la Peña commented on CASSANDRA-16817:
-----------------------------------------------

Here is a trivial patch changing the log message:

||branch||CI||
|[3.0|https://github.com/apache/cassandra/compare/cassandra-3.0...adelapena:16817-3.0]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/700/workflows/b2490065-bb4b-43d9-aba0-14d7453ddc37]|
|[3.11|https://github.com/apache/cassandra/compare/cassandra-3.11...adelapena:16817-3.11]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/703/workflows/957642e6-6479-46e1-93a9-6b2d88860bca]|
|[4.0|https://github.com/apache/cassandra/compare/cassandra-4.0...adelapena:16817-4.0]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/702/workflows/36bd79c4-829c-41af-bee0-a9ad96e70f80]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/702/workflows/68d04e1c-f503-48d7-8959-4aa77ac2c3fd]|
|[trunk|https://github.com/apache/cassandra/compare/trunk...adelapena:16817-trunk]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/701/workflows/b3e17b4f-f2a1-42ab-87ea-a8d2a868ad17]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/701/workflows/3bf996fd-d041-4f7c-8f67-1510ad896d6f]|

> Fix ERROR message which prints data information in the logs
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-16817
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16817
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Feature/Materialized Views
>            Reporter: Andres de la Peña
>            Assignee: Andres de la Peña
>            Priority: Normal
>             Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> {{StorageProxy.mutateMV}} might log [an error message|https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/service/StorageProxy.java#L880]
that prints user data in the logs beyond the row key, for example:
> {code}
> ERROR [MutationStage-2] 2021-07-28 13:08:52,609 StorageProxy.java:1002 - Error applying
local view update to keyspace k: Mutation(keyspace='k', key='00000001', modifications=[
>   [k.mv] key=1 partition_deletion=deletedAt=-9223372036854775808, localDeletion=2147483647
columns=[[] | []]
>     Row[info=[ts=1627474132606719] ]: k=0, v=MY CONFIDENTIAL DATA |
> ])
> {code}
> We should probably change that log message so it doesn't print the entire mutation but
only the keyspace, tables and partition key of the mutation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message