cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Miklosovic (Jira)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14564) Adding regular column to COMPACT tables without clustering columns should trigger an InvalidRequestException
Date Mon, 16 Aug 2021 16:21:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399826#comment-17399826
] 

Stefan Miklosovic commented on CASSANDRA-14564:
-----------------------------------------------

Hi [~blerer],

Vincent is not longer with us in the company so I guess he is not going to deliver this anytime
soon.

I have fixed it here: [https://github.com/apache/cassandra/pull/1145] (I ll test that afterwards)

Would you like to take a look?

One question I have, that case starts with "if it is dense then ..." with an exception message
which is actually more suitable for this situation we are trying to solve, is that some kind
of a legacy?

Next, this description of the solution in the descripion of this ticket confused me a little
bit:

... attempts to add a regular column to a a COMPACT TABLE without clustering columns ....

if I did if (meta.isCompactTable && meta.clusteringColumns().isEmpty) throw ...

on the model example it has not worked so I guess just mere checking on meta.isCompactTable()
should be enough ...

>  Adding regular column to COMPACT tables without clustering columns should trigger an
InvalidRequestException
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-14564
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14564
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Legacy/Core, Legacy/CQL
>            Reporter: Laxmikant Upadhyay
>            Priority: Normal
>              Labels: lhf
>             Fix For: 3.0.x, 3.11.x, 4.0.x
>
>
> I have upgraded my system from cassandra 2.1.16 to 3.11.2. We had some tables with COMPACT
STORAGE enabled. We see some weird   behaviour of cassandra while adding a column into it.
> Cassandra does not give any error while altering  however the added column is invisible. 
> Same behaviour when we create a new table with compact storage and try to alter it. Below
is the commands ran in sequence: 
>  
> {code:java}
> x@cqlsh:xuser> CREATE TABLE xuser.employee(emp_id int PRIMARY KEY,emp_name text, emp_city
text, emp_sal varint, emp_phone varint ) WITH  COMPACT STORAGE;
> x@cqlsh:xuser> desc table xuser.employee ;
> CREATE TABLE xuser.employee (
> emp_id int PRIMARY KEY,
> emp_city text,
> emp_name text,
> emp_phone varint,
> emp_sal varint
> ) WITH COMPACT STORAGE
> AND bloom_filter_fp_chance = 0.01
> AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'}
> AND comment = ''
> AND compaction = {'class': 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy',
'max_threshold': '32', 'min_threshold': '4'}
> AND compression = {'chunk_length_in_kb': '64', 'class': 'org.apache.cassandra.io.compress.LZ4Compressor'}
> AND crc_check_chance = 1.0
> AND dclocal_read_repair_chance = 0.1
> AND default_time_to_live = 0
> AND gc_grace_seconds = 864000
> AND max_index_interval = 2048
> AND memtable_flush_period_in_ms = 0
> AND min_index_interval = 128
> AND read_repair_chance = 0.0
> AND speculative_retry = '99PERCENTILE';{code}
> Now altering the table by adding a new column:
>   
> {code:java}
> x@cqlsh:xuser>  alter table employee add profile text;
> x@cqlsh:xuser> desc table xuser.employee ;
> CREATE TABLE xuser.employee (
>     emp_id int PRIMARY KEY,
>     emp_city text,
>     emp_name text,
>     emp_phone varint,
>     emp_sal varint
> ) WITH COMPACT STORAGE
>     AND bloom_filter_fp_chance = 0.01
>     AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'}
>     AND comment = ''
>     AND compaction = {'class': 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy',
'max_threshold': '32', 'min_threshold': '4'}
>     AND compression = {'chunk_length_in_kb': '64', 'class': 'org.apache.cassandra.io.compress.LZ4Compressor'}
>     AND crc_check_chance = 1.0
>     AND dclocal_read_repair_chance = 0.1
>     AND default_time_to_live = 0
>     AND gc_grace_seconds = 864000
>     AND max_index_interval = 2048
>     AND memtable_flush_period_in_ms = 0
>     AND min_index_interval = 128
>     AND read_repair_chance = 0.0
>     AND speculative_retry = '99PERCENTILE';
> {code}
> notice that above desc table result does not have newly added column profile. However
when i try to add it again it gives column already exist;
> {code:java}
> x@cqlsh:xuser>  alter table employee add profile text;
> InvalidRequest: Error from server: code=2200 [Invalid query] message="Invalid column
name profile because it conflicts with an existing column"
> x@cqlsh:xuser> select emp_name,profile from employee;
>  emp_name | profile
> ----------+---------
> (0 rows)
> x@cqlsh:xuser>
> {code}
> Inserting also behaves strange:
> {code:java}
> x@cqlsh:xuser> INSERT INTO employee (emp_id , emp_city , emp_name , emp_phone , emp_sal
,profile) VALUES ( 1, 'ggn', 'john', 123456, 50000, 'SE');
> InvalidRequest: Error from server: code=2200 [Invalid query] message="Some clustering
keys are missing: column1"
> x@cqlsh:xuser> INSERT INTO employee (emp_id , emp_city , emp_name , emp_phone , emp_sal
,profile,column1) VALUES ( 1, 'ggn', 'john', 123456, 50000, 'SE',null);
> x@cqlsh:xuser> select * from employee;
>  emp_id | emp_city | emp_name | emp_phone | emp_sal
> --------+----------+----------+-----------+---------
> (0 rows)
> {code}
> *How to solve that ticket* ([~blerer])--------------------------------------------------------------------------------------

> Adding regular columns to non-dense compact tables should be forbidden as it is the case
for other column types. To do that {{AlterTableStatement}} should be modified to fire an {{InvalidRequestException}}
when a user attempts to add a regular column to a  a COMPACT TABLE without clustering columns.
> The fix should include a unit tests for that scenario  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message