cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ekaterina Dimitrova (Jira)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-16835) Scrub still uses "row" to mean "partitions", and has broken code
Date Mon, 16 Aug 2021 21:22:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17400015#comment-17400015
] 

Ekaterina Dimitrova commented on CASSANDRA-16835:
-------------------------------------------------

Great, thanks. Then squash, rebase and then these are last(hopefully) CI runs:
||Patch||CI||
|[3.11|https://github.com/ekaterinadimitrova2/cassandra/commit/ed49d3edad9b9e86952808e7585f6dce69785e2b]|[CircleCI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1073/workflows/5fb0b764-bfc0-4409-9d3b-b65fe07f13e0]|
|[4.0|https://github.com/ekaterinadimitrova2/cassandra/commit/af10a0c1f6f9824b4933fb65d42c860c0fc4766a]|[CircleCI
j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1074/workflows/40500114-c53e-42b3-bee1-d48b0c1e3e20],
[j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1074/workflows/5e0527f6-a1d1-4be6-af1d-dc120395bdf7]|
|[trunk|https://github.com/ekaterinadimitrova2/cassandra/commit/6af63779aa6f4dab4b184a0e4ff612ec3c6c3536]|[CircleCI
j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1075/workflows/8d4f1f0f-1e46-4e52-8064-ceaa02735a05],
[j11| https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1075/workflows/a326d796-3350-4655-a2c9-80175f46a776]|

> Scrub still uses "row" to mean "partitions", and has broken code
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-16835
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16835
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tool/nodetool
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 3.11.x, 4.0.x, 4.x
>
>
> 2 issues in the scrub code:
>  1) It still uses "row" to mean "partition". And not only in the code, but also in user
messages. As we've fairly systematically remove such instances elsewhere in 3.0+, having it
in scrub is going to confuse users which will almost surely misinterpret the results. If scrub
says that it dropped 2 unreadable "rows" from your sstable, you might be ok with that when
we're actually talking about CQL rows, but not if we talk of 2 full partitions.
>  2) There is a branch at the end of scrub that is supposed to handle the case where scrubbing
a sstable generates no output at all (the sstable is completely hosed usually), mostly providing
a more user friendly message. The code is broken (and has been for a long time, since CASSANDRA-7066
I believe) however such that this branch can simply never be taken (even when it should).
While admittedly pretty minor, no reason to leave it that way.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message