cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Caleb Rackliffe (Jira)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-16883) Weak visibility guarantees of Accumulator can lead to failure to recognize digest mismatches
Date Mon, 30 Aug 2021 17:01:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-16883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406048#comment-17406048
] 

Caleb Rackliffe edited comment on CASSANDRA-16883 at 8/30/21, 5:00 PM:
-----------------------------------------------------------------------

||branch||Circle CI||Apache CI|
|[3.0|https://github.com/apache/cassandra/pull/1173]|[J8|https://app.circleci.com/pipelines/github/maedhroz/cassandra?branch=CASSANDRA-16883-3.0]|[1078|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1078/]

(This should be a pretty clean merge up to 3.11, and won't be necessary in 4.0.)


was (Author: maedhroz):
||branch||Circle CI||Apache CI|
|[3.0|https://github.com/apache/cassandra/pull/1173]|[J8|https://app.circleci.com/pipelines/github/maedhroz/cassandra?branch=CASSANDRA-16883-3.0]|[1078|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1078/]

> Weak visibility guarantees of Accumulator can lead to failure to recognize digest mismatches
> --------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-16883
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16883
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Consistency/Coordination
>            Reporter: Caleb Rackliffe
>            Assignee: Caleb Rackliffe
>            Priority: Normal
>             Fix For: 3.0.x, 3.11.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The context for this problem is largely the same as CASSANDRA-16807. The difference is
that for 4.0+, CASSANDRA-16097 added an assertion to {{DigestResolver#responseMatch()}} that
ensures the responses snapshot has at least one visible element (although of course only one
element trivially cannot generate a mismatch and short-circuits immediately). In 3.0 and 3.11,
this assertion does not exist, and when the underlying problem occurs (i.e. zero responses
are visible on {{Accumulator}} when there should be 2), we can silently avoid the digest matching
entirely. This seems like it would make it both impossible to do a potentially necessary full
data read to resolve the correct response and prevent repair.
> The fix here should be similar to the one in CASSANDRA-16807, although there might be
some test infrastructure that needs porting in order to make that work.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message