cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Caleb Rackliffe (Jira)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-16900) org.apache.cassandra.db.rows.ArrayCell#unsharedHeapSizeExcludingData includes data twice
Date Mon, 30 Aug 2021 21:01:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-16900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406937#comment-17406937
] 

Caleb Rackliffe commented on CASSANDRA-16900:
---------------------------------------------

[~dcapwell] I'm about ready to just say LGTM on this, but there is one thing that might be
worth clarifying...

If the behavior we want from the {{unsharedHeapSizeExcludingData()}} methods of {{ArrayCell}}
and {{BufferCell}} is that they take nothing from the {{value}} field other than the size
of its reference, things are fine as they are. The only thing we might want to do is remove
the {{ObjectSizes#sizeOnHeapExcludingData()}} method and use your new {{sizeOfEmptyHeapByteBuffer()}}
instead.

On the other hand, if that isn't what was originally intended (and the {{ByteBuffer}} argument
on {{sizeOnHeapExcludingData()}} makes me wonder), then we'd have to figure out what's going
on. I think the argument is just an oversight from a refactoring.

> org.apache.cassandra.db.rows.ArrayCell#unsharedHeapSizeExcludingData includes data twice
> ----------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-16900
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16900
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Legacy/Local Write-Read Paths
>            Reporter: David Capwell
>            Assignee: David Capwell
>            Priority: Normal
>             Fix For: 4.0.1, 4.1
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> org.apache.cassandra.db.rows.ArrayCell#unsharedHeapSizeExcludingData includes data and
adds the length; so includes data twice



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message