cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andres de la Peña (Jira) <>
Subject [jira] [Commented] (CASSANDRA-16871) Add resource flags to CircleCi config generation script
Date Wed, 01 Sep 2021 14:39:00 GMT


Andres de la Peña commented on CASSANDRA-16871:

Thanks for the review.

Committed to 3.0 as [e4b37c3271c0e91407816d3c5370ebc8b95a615a|]
and merged to [3.11|],
and [trunk|].

> Add resource flags to CircleCi config generation script
> -------------------------------------------------------
>                 Key: CASSANDRA-16871
>                 URL:
>             Project: Cassandra
>          Issue Type: Task
>          Components: CI
>            Reporter: Andres de la Peña
>            Assignee: Andres de la Peña
>            Priority: Low
>             Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
> Currently we have three versions of the CircleCI config file using different resources.
Changing the resources configuration is as easy as copying the desired template file, for
> {code}
> cp .circleci/config.yml.MIDRES .circleci/config.yml
> {code}
> If we want to make changes to the file, for example to set a specific dtest repo or running
the test multiplexer, we can run the provided generation script, copy the template file and
probably exclude the additional changes:
> {code}
> # edit config-2_1.yml
> .circleci/
> cp .circleci/config.yml.MIDRES .circleci/config.yml
> # undo the changes in config.yml.LOWRES, config.yml.MIDRES and config.yml.HIGHRES
> {code}
> A very common alternative to this is just editing the environment variables in the automatically
generated {{config.yml}} file, which are repeated some 19 times across the file:
> {code}
> cp .circleci/config.yml.MIDRES .circleci/config.yml
> # edit config.yml, where env vars are repeated
> {code}
> I think we could do this slightly easier by adding a set of flags to the generation script
to apply the resources patch directly to {{config.yml}}, without changing the templates:
> {code}
> # edit config-2_1.yml
> .circleci/ -m
> {code}
> This has the advantage of not requiring manually editing the automatically generated
file and also providing some validation.

This message was sent by Atlassian Jira

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message