cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ekaterina Dimitrova (Jira)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-16871) Add resource flags to CircleCi config generation script
Date Wed, 01 Sep 2021 17:13:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-16871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408284#comment-17408284
] 

Ekaterina Dimitrova commented on CASSANDRA-16871:
-------------------------------------------------

Thank you for the patch!

Maybe we can send now mail to the dev list to inform people that they can start using those
if they want to?

> Add resource flags to CircleCi config generation script
> -------------------------------------------------------
>
>                 Key: CASSANDRA-16871
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16871
>             Project: Cassandra
>          Issue Type: Task
>          Components: CI
>            Reporter: Andres de la Peña
>            Assignee: Andres de la Peña
>            Priority: Low
>             Fix For: 3.0.26, 3.11.12, 4.1, 4.0.2
>
>
> Currently we have three versions of the CircleCI config file using different resources.
Changing the resources configuration is as easy as copying the desired template file, for
example:
> {code}
> cp .circleci/config.yml.MIDRES .circleci/config.yml
> {code}
> If we want to make changes to the file, for example to set a specific dtest repo or running
the test multiplexer, we can run the provided generation script, copy the template file and
probably exclude the additional changes:
> {code}
> # edit config-2_1.yml
> .circleci/generate.sh
> cp .circleci/config.yml.MIDRES .circleci/config.yml
> # undo the changes in config.yml.LOWRES, config.yml.MIDRES and config.yml.HIGHRES
> {code}
> A very common alternative to this is just editing the environment variables in the automatically
generated {{config.yml}} file, which are repeated some 19 times across the file:
> {code}
> cp .circleci/config.yml.MIDRES .circleci/config.yml
> # edit config.yml, where env vars are repeated
> {code}
> I think we could do this slightly easier by adding a set of flags to the generation script
to apply the resources patch directly to {{config.yml}}, without changing the templates:
> {code}
> # edit config-2_1.yml
> .circleci/generate.sh -m
> {code}
> This has the advantage of not requiring manually editing the automatically generated
file and also providing some validation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message