commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [VOTE] Release Apache Commons VFS Project 2.4.1 based on RC1
Date Tue, 13 Aug 2019 01:45:15 GMT
On Mon, Aug 12, 2019 at 6:28 PM Bruno P. Kinoshita <kinow@apache.org> wrote:

>  I am not sure.
> I tried `mvn clean test` (building from tag FWIW) and it passed on $work
> notebook (same version of Ubuntu and Java, but in virtualbox hosted on
> win10pro).
>

I like building RCs from tags as well, it feels like the most direct and
closest to the truth way to build as opposed to building from a src zip/tar.


> The tried `mvn clean install site -P japicmp`, and got the same error as
> yesterday.
> Tried the same command two times more, and the same test failed as before.
> Just to check, tried `mvn clean test`, and it passed again.
> Then `mvn clean test install`, also passed.
> And `mvn clean test install site`, failed.
>

So for you there is something weird that happens when building the site
takes place. I normally build on Windows 10 but I tried on Ubuntu inside
VirtualBox and I could reproduce your issue with the tags for 2.3, 2.4, and
2.4.1-RC1!

Tests run: 95, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 4.407 sec
<<< FAILURE! - in
org.apache.commons.vfs2.provider.local.test.LocalProviderTestCase
testRandomSetLength(org.apache.commons.vfs2.test.ProviderRandomSetLengthTests)
 Time elapsed: 0.009 sec  <<< FAILURE!
java.lang.AssertionError:
file:///home/ggregory/commons-vfs/commons-vfs2/target/test-classes/test-data/write-tests/random_write.txt
expected:<1> but was:<20>
        at org.junit.Assert.fail(Assert.java:88)

I am not sure why you'd want to double up testing since install causes test
to run, so this is enough: mvn clean install site. But that fails the test
too, as does a simple 'mvn clean site' so there is something odd about
building the site on Linux. Running 'mvn clean install' is fine.

I wonder if this is a surefire issue or the JVM or a test class hanging on
to a file handle too long. All is well on Windows which is where I build
though.

Unless someone wants to spend time figuring this out, I say we continue
this research in master for the next release.

Gary


>
>
>     On Tuesday, 13 August 2019, 1:57:51 am NZST, Gary Gregory <
> garydgregory@gmail.com> wrote:
>
>  Could you be having access rights issues? The build 'mvn -V clean test'
> passes for me under VirtualBox with:
>
> Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 11.0.4, vendor: Ubuntu, runtime:
> /usr/lib/jvm/java-11-openjdk-amd64
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.18.0-20-generic", arch: "amd64", family:
> "unix"
>
> Gary
>
>
> On Mon, Aug 12, 2019 at 5:47 AM Bruno P. Kinoshita <kinow@apache.org>
> wrote:
>
> >  Hi Gary,
> > >I have tested this with 'mvn -V clean install site -P japicmp' using:
> > It failed with `mvn clean test install site`, then tried the command
> > above, and failed the same way. My env:
> > Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> > 2018-06-18T06:33:14+12:00)
> > Maven home: /opt/apache-maven-3.5.4
> > Java version: 1.8.0_222, vendor: Private Build, runtime:
> > /usr/lib/jvm/java-8-openjdk-amd64/jre
> > Default locale: en_NZ, platform encoding: UTF-8
> > OS name: "linux", version: "4.15.0-55-generic", arch: "amd64", family:
> > "unix"
> > Test failure:
> >
> > Results :
> >
> > Failed tests:
> >
> >
> org.apache.commons.vfs2.test.ProviderWriteTests.testFileCreate(org.apache.commons.vfs2.test.ProviderWriteTests)
> >  Run 1: PASS
> >  Run 2: PASS
> >  Run 3: PASS
> >  Run 4: PASS
> >  Run 5: PASS
> >  Run 6: PASS
> >  Run 7: PASS
> >  Run 8: PASS
> >  Run 9: PASS
> >  Run 10: PASS
> >  Run 11: PASS
> >  Run 12: PASS
> >  Run 13: PASS
> >  Run 14: PASS
> >  Run 15: PASS
> >  Run 16: PASS
> >  Run 17: PASS
> >  Run 18: PASS
> >  Run 19: PASS
> >  Run 20: PASS
> >  Run 21: PASS
> >  Run 22: PASS
> >  Run 23: PASS
> >  Run 24: PASS
> >  Run 25:
> >
> ProviderWriteTests>AbstractProviderTestCase.runTest:201->testFileCreate:112
> > expected:<0> but was:<112>
> >  Run 26: PASS
> >  Run 27: PASS
> >  Run 28: PASS
> >  Run 29: PASS
> >
> >
> > Tests run: 2816, Failures: 1, Errors: 0, Skipped: 6
> >
> > [INFO]
> > ------------------------------------------------------------------------
> > [INFO] Reactor Summary:
> > [INFO]
> > [INFO] Apache Commons VFS Project 2.4.1 ................... SUCCESS [
> > 44.949 s]
> > [INFO] Apache Commons VFS ................................. FAILURE
> [05:09
> > min]
> > [INFO] Apache Commons VFS Examples ........................ SKIPPED
> > [INFO] Apache Commons VFS Distribution 2.4.1 .............. SKIPPED
> > [INFO]
> > ------------------------------------------------------------------------
> >
> > CheersBruno
> >
> >    On Monday, 12 August 2019, 12:50:42 am NZST, Gary Gregory <
> > ggregory@apache.org> wrote:
> >
> >  We have fixed 2 bugs and enhanced Javadocs since Apache Commons VFS 2.4
> > was
> > released, so I would like to release Apache Commons VFS 2.4.1.
> >
> > Apache Commons VFS 2.4.1 RC1 is available for review here:
> >    https://dist.apache.org/repos/dist/dev/commons/vfs/2.4.1-RC1 (svn
> > revision 35198)
> >
> > The Git tag commons-vfs-2.4.1-RC1 commit for this RC is
> > eabdee306d5b0a73859a0aa841a5c0ccfe8b337a which you can browse here:
> >
> >
> >
> https://gitbox.apache.org/repos/asf?p=commons-vfs.git;a=commit;h=eabdee306d5b0a73859a0aa841a5c0ccfe8b337a
> > You may checkout this tag using:
> >    git clone https://gitbox.apache.org/repos/asf/commons-vfs.git
> --branch
> > commons-vfs-2.4.1-RC1 commons-vfs-2.4.1-RC1
> >
> > Maven artifacts are here:
> >
> >
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1458/org/apache/commons/commons-vfs2/2.4.1/
> >
> > These are the artifacts and their hashes:
> >
> >
> >
> /org/apache/commons/commons-vfs2-distribution/2.4.1/commons-vfs2-distribution-2.4.1.pom
> > (SHA1: d334baee497ee14d78581a1f4dc2ef203744ba34)
> >
> >
> /org/apache/commons/commons-vfs2-distribution/2.4.1/commons-vfs2-distribution-2.4.1-javadoc.jar
> > (SHA1: 0daef39eeb8130c35d5341f9cb863b31496b245b)
> >
> /org/apache/commons/commons-vfs2/2.4.1/commons-vfs2-2.4.1-test-sources.jar
> > (SHA1: f9abe836aedb9e78c784bec4a98d72af95d664ef)
> > /org/apache/commons/commons-vfs2/2.4.1/commons-vfs2-2.4.1-javadoc.jar
> > (SHA1: 7e065d5b0d06f5bc809d867f4ee212fd12e301d5)
> > /org/apache/commons/commons-vfs2/2.4.1/commons-vfs2-2.4.1.pom
> > (SHA1: 80b0fec7213ddeb627193fcf570e7d961aa88048)
> > /org/apache/commons/commons-vfs2/2.4.1/commons-vfs2-2.4.1.jar
> > (SHA1: 2b041628c3cb436d8eee25f78603f04eb5e817a5)
> > /org/apache/commons/commons-vfs2/2.4.1/commons-vfs2-2.4.1-tests.jar
> > (SHA1: 9239c38d59560a76eea5108bb92622cf9e0d2f2d)
> > /org/apache/commons/commons-vfs2/2.4.1/commons-vfs2-2.4.1-sources.jar
> > (SHA1: 7a8f46ba636106c51512cb319c782fcdf242c009)
> >
> >
> /org/apache/commons/commons-vfs2-project/2.4.1/commons-vfs2-project-2.4.1-site.xml
> > (SHA1: baca67a9f6be69b52869c2ec49b7487bdbd6bc9f)
> >
> >
> /org/apache/commons/commons-vfs2-project/2.4.1/commons-vfs2-project-2.4.1-javadoc.jar
> > (SHA1: dcbb400154bb7ee1868fa0f2e800b7fd910be68f)
> >
> >
> /org/apache/commons/commons-vfs2-project/2.4.1/commons-vfs2-project-2.4.1.pom
> > (SHA1: 0d75228dbd15638c135c4afa914b46a520425b83)
> >
> >
> /org/apache/commons/commons-vfs2-examples/2.4.1/commons-vfs2-examples-2.4.1-javadoc.jar
> > (SHA1: ef6cf5ae11caacfff78cf9d25387dd847593d61a)
> >
> >
> /org/apache/commons/commons-vfs2-examples/2.4.1/commons-vfs2-examples-2.4.1-sources.jar
> > (SHA1: 1eafbd241b3be42f3ac012f82b156de8319953a0)
> >
> >
> /org/apache/commons/commons-vfs2-examples/2.4.1/commons-vfs2-examples-2.4.1.pom
> > (SHA1: 79df4540ba2fb5a33cdccfa4228a16215d290763)
> >
> >
> /org/apache/commons/commons-vfs2-examples/2.4.1/commons-vfs2-examples-2.4.1.jar
> > (SHA1: a7c5c5dc0f5dd83f8bc58ef0c50f3c1d336fd86e)
> >
> > I have tested this with 'mvn -V clean install site -P japicmp' using:
> >
> > Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
> > 2019-04-04T15:00:29-04:00)
> > Maven home: C:\Java\apache-maven-3.6.1\bin\..
> > Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: C:\Program
> > Files\Java\jdk1.8.0_221\jre
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> >
> > Details of changes since 2.4 are in the release notes:
> >
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.4.1-RC1/RELEASE-NOTES.txt
> >
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.4.1-RC1/site/changes-report.html
> >
> > Site:
> >
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.4.1-RC1/site/index.html
> >    (note some *relative* links are broken and the 2.4.1 directories are
> > not yet created - these will be OK once the site is deployed.)
> >
> > JApiCmp Report (compared to 2.4):
> >
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.4.1-RC1/site/commons-vfs2/japicmp.html
> >
> > RAT Report:
> >
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.4.1-RC1/site/rat-report.html
> >
> > KEYS:
> >  https://www.apache.org/dist/commons/KEYS
> >
> > Please review the release candidate and vote.
> > This vote will close no sooner that 72 hours from now.
> >
> >  [ ] +1 Release these artifacts
> >  [ ] +0 OK, but...
> >  [ ] -0 OK, but really should fix...
> >  [ ] -1 I oppose this release because...
> >
> > Thank you,
> >
> > Gary Gregory,
> > Release Manager (using key 86fdc7e2a11262cb)
> >
> > For following is intended as a helper and refresher for reviewers.
> >
> > Validating a release candidate
> > ==============================
> >
> > These guidelines are NOT complete.
> >
> > Requirements: Git, Java, Maven.
> >
> > You can validate a release from a release candidate (RC) tag as follows.
> >
> > 1) Clone and checkout the RC tag
> >
> > git clone https://gitbox.apache.org/repos/asf/commons-vfs.git --branch
> > commons-vfs-2.4.1-RC1 commons-vfs-2.4.1-RC1
> > cd commons-vfs-2.4.1-RC1
> >
> > 2) Check Apache licenses
> >
> > This step is not required if the site includes a RAT report page which
> you
> > then must check.
> >
> > mvn apache-rat:check
> >
> > 3) Check binary compatibility
> >
> > Newer components use JApiCmp with the japicmp Maven Profile:
> >
> > This step is not required if the site includes a JApiCmp report page
> which
> > you then must check.
> >
> > mvn install -DskipTests -P japicmp japicmp:cmp
> >
> > 4) Build the package
> >
> > mvn -V clean package
> >
> > You can record the Maven and Java version produced by -V in your VOTE
> > reply.
> > To gather OS information from a command line:
> > Windows: ver
> > Linux: uname -a
> >
> > 5) Build the site for a single module project
> >
> > Note: Some plugins require the components to be installed instead of
> > packaged.
> >
> > mvn site
> > Check the site reports in:
> > - Windows: target\site\index.html
> > - Linux: target/site/index.html
> >
> > 6) Build the site for a multi-module project
> >
> > mvn site
> > mvn site:stage
> > Check the site reports in:
> > - Windows: target\site\index.html
> > - Linux: target/site/index.html
> >
> > -the end-
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message