commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <>
Subject [jira] [Commented] (LANG-747) NumberUtils does not handle Long Hex numbers
Date Wed, 12 Sep 2012 06:13:08 GMT


Henri Yandell commented on LANG-747:

Originally: A combination of the original code being written for Java 1.1 (on a Psion netBook!)
and my lack of awareness/knowledge when moving to Java 1.2. :)

For leading zeroes - could you look for the first non-zero character and then length check?
> NumberUtils does not handle Long Hex numbers
> --------------------------------------------
>                 Key: LANG-747
>                 URL:
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.math.*
>            Reporter: Sebb
> NumberUtils.createLong() does not handle hex numbers, but createInteger() handles hex
and octal.
> This seems odd.
> NumberUtils.createNumber() assumes that hex numbers can only be Integer.
> Again, why not handle bigger Hex numbers?
> ==
> It is trivial to fix createLong() - just use Long.decode() instead of valueOf().
> It's not clear why this was not done originally - the decode() method was added to both
Integer and Long in Java 1.2.
> Fixing createNumber() is also fairly easy - if the hex string has more than 8 digits,
use Long.
> Should we allow for leading zeros in an Integer? 
> If not, the length check is trivial.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message