commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <>
Subject [jira] [Commented] (LANG-804) Redundant check for zero in HashCodeBuilder ctor
Date Sat, 29 Sep 2012 12:18:08 GMT


Sebb commented on LANG-804:

More to the point, perhaps the ctor should check for positive numbers.

Does it make sense for the user to provide negative numbers?
> Redundant check for zero in HashCodeBuilder ctor
> ------------------------------------------------
>                 Key: LANG-804
>                 URL:
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.builder.*
>            Reporter: Sebb
>            Priority: Minor
> The HashCodeBuilder(int, int) ctor checks both parameters for zero, as well as checking
for an odd number.
> Zero is never odd, so the zero check could be eliminated.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message