commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simone Tripodi (JIRA)" <>
Subject [jira] [Commented] (DIGESTER-171) Add DefaultThrowingErrorHandler to Digester API.
Date Mon, 10 Sep 2012 19:00:08 GMT


Simone Tripodi commented on DIGESTER-171:

Nice thought, Nick!

patches (with testcases ;)) are more welcome, if you could provide one I would be more than
happy to review and check it in.

Many thanks in advance!
> Add DefaultThrowingErrorHandler to Digester API.
> ------------------------------------------------
>                 Key: DIGESTER-171
>                 URL:
>             Project: Commons Digester
>          Issue Type: Improvement
>    Affects Versions: 3.2
>            Reporter: Nick Williams
>            Priority: Minor
>   Original Estimate: 1h
>  Remaining Estimate: 1h
> The current default error handling behavior is for the SAX parses to NOT throw exceptions
when they occur, but instead to log them to stderr. This is fine and I am not suggesting that
be changed. However, there is a wiki article (
that describes the common task of implementing an error handler that throws encountered errors.
> If this is so common, it would seem that including such an error handler in the API would
be a very convenient thing to do.
> I propose that the following class be added to the digester to make it convenient for
anyone to turn on this behavior:
> {code}package org.apache.commons.digester3;
> import org.xml.sax.ErrorHandler;
> import org.xml.sax.SAXException;
> import org.xml.sax.SAXParseException;
> public class DefaultThrowingErrorHandler implements ErrorHandler
> {
>     @Override
>     public void warning(SAXParseException e) throws SAXException
>     {
>         throw e;
>     }
>     @Override
>     public void error(SAXParseException e) throws SAXException
>     {
>         throw e;
>     }
>     @Override
>     public void fatalError(SAXParseException e) throws SAXException
>     {
>         throw e;
>     }
> }{code}
> Furthermore, I propose that the DigesterLoader and Digester classes have setThrowEncounteredSAXErrors(boolean)
methods that set the error handler to the DefaultThrowingErrorHandler..

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message