commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-1417) Add @FunctionalInterface to ThreadPredicate and ThreadGroupPredicate
Date Tue, 04 Sep 2018 09:19:00 GMT

    [ https://issues.apache.org/jira/browse/LANG-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602808#comment-16602808
] 

ASF GitHub Bot commented on LANG-1417:
--------------------------------------

GitHub user britter opened a pull request:

    https://github.com/apache/commons-lang/pull/351

    LANG-1417: Add @FunctionalInterface to ThreadPredicate and ThreadGrou…

    …pPredicate

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/britter/commons-lang LANG-1417

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/351.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #351
    
----
commit 54f8d3c02abe04765ffe957e7d412bde2adf58c1
Author: Benedikt Ritter <britter@...>
Date:   2018-09-04T09:16:55Z

    LANG-1417: Add @FunctionalInterface to ThreadPredicate and ThreadGroupPredicate

----


> Add @FunctionalInterface to ThreadPredicate and ThreadGroupPredicate
> --------------------------------------------------------------------
>
>                 Key: LANG-1417
>                 URL: https://issues.apache.org/jira/browse/LANG-1417
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>            Reporter: Benedikt Ritter
>            Priority: Major
>             Fix For: 3.9
>
>
> Since we upgraded the Java language requirement to Java 8, we can add the @FunctionalInterface
annotation to ThreadGroupPredicate and ThreadPredicate.
>  
> Our initial plan of letting ThreadGroupPredicate and ThreadPredicate inherit vom Predicate
is not possible since we have implementations that would then inherit from both Predicate<Thread>
and Predicate<ThreadGroup> which is not possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message