commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From britter <...@git.apache.org>
Subject [GitHub] commons-lang pull request #354: Convert tests for Validate.isTrue overloads ...
Date Wed, 05 Sep 2018 12:31:37 GMT
GitHub user britter opened a pull request:

    https://github.com/apache/commons-lang/pull/354

    Convert tests for Validate.isTrue overloads to @Nested test

    Proposal for a better structure of tests using `@Nested`. Each method should have it's
own `@Nested` container which is called like the method. Inside that container each overload
has it's own `@Nested` container. I did this for `Validate.isTrue` to show the approach.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/britter/commons-lang nested-validate-test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/354.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #354
    
----
commit aad2db8b12b8c61556df9df7de4fadc927633504
Author: Benedikt Ritter <britter@...>
Date:   2018-09-05T12:26:25Z

    Convert tests for Validate.isTrue overloads to @Nested test

----


---

Mime
View raw message