drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aman Sinha" <asi...@maprtech.com>
Subject Review Request 16093: Patch for DRILL-318
Date Fri, 06 Dec 2013 22:37:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16093/
-----------------------------------------------------------

Review request for drill.


Bugs: DRILL-318
    https://issues.apache.org/jira/browse/DRILL-318


Repository: drill-git


Description
-------

Added template-based code generation for aggregate functions: min, max, sum, count, avg. 
These support several data types both nullable and non-nullable.


Diffs
-----

  common/src/main/java/org/apache/drill/common/expression/fn/AggregationFunctions.java 5b46b786e0bad694669099ba59c8a3ce89e13b6f

  exec/java-exec/src/main/codegen/config.fmpp cd2b2cce1c7d89b389404e24d9a8110e99388202 
  exec/java-exec/src/main/codegen/data/AggrTypes1.tdd PRE-CREATION 
  exec/java-exec/src/main/codegen/data/AggrTypes2.tdd PRE-CREATION 
  exec/java-exec/src/main/codegen/templates/AggrTypeFunctions1.java PRE-CREATION 
  exec/java-exec/src/main/codegen/templates/AggrTypeFunctions2.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/agg/impl/CountFunctions.java
b0939f1fea7876b7f1ba6c522438b52af31ef6cf 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/agg/impl/SumFunctions.java 57905fed5c7567475c43f3266a050be14b8af9fb


Diff: https://reviews.apache.org/r/16093/diff/


Testing
-------


Thanks,

Aman Sinha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message