drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@gmail.com>
Subject Re: Review Request 15824: Patch for DRILL-281
Date Sun, 08 Dec 2013 08:07:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15824/
-----------------------------------------------------------

(Updated Dec. 8, 2013, 8:07 a.m.)


Review request for drill and Jacques Nadeau.


Bugs: DRILL-281
    https://issues.apache.org/jira/browse/DRILL-281


Repository: drill-git


Description
-------

Verified refCount is 0 after broadcast, use async SendBatch call while broadcasting.


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java
b8a7247 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java 040a495

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/BroadcastExchange.java
PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/BroadcastSender.java
PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java e1fb3ae

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/broadcastsender/BroadcastSenderCreator.java
PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/broadcastsender/BroadcastSenderRootExec.java
PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/record/WritableBatch.java e9b56db 
  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/bit/BitTunnel.java 4ce826c 
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestBroadcastExchange.java
PRE-CREATION 
  exec/java-exec/src/test/resources/sender/broadcast_exchange.json PRE-CREATION 
  exec/java-exec/src/test/resources/sender/broadcast_exchange_long_run.json PRE-CREATION 

Diff: https://reviews.apache.org/r/15824/diff/


Testing
-------


Thanks,

Timothy Chen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message