drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Nadeau (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-324) Contributing wiki should mention the correct command to generate patch
Date Sat, 14 Dec 2013 16:57:08 GMT

    [ https://issues.apache.org/jira/browse/DRILL-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13848401#comment-13848401
] 

Jacques Nadeau commented on DRILL-324:
--------------------------------------

[~tnachen], can you add Sumit as a contributor to the wiki so he can make these updates?

> Contributing wiki should mention the correct command to generate patch
> ----------------------------------------------------------------------
>
>                 Key: DRILL-324
>                 URL: https://issues.apache.org/jira/browse/DRILL-324
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Sumit Kumar
>            Assignee: Sumit Kumar
>            Priority: Minor
>
> Sections on creating a patch [1] and applying a patch [2] are not in sync. To be consistent,
[1] should mention the correct command i.e. [3] instead of [4]
> 1. https://cwiki.apache.org/confluence/display/DRILL/Contributing#Contributing-Creatingapatch
> 2. https://cwiki.apache.org/confluence/display/DRILL/Contributing#Contributing-Applyingapatch
> 3. git diff --no-prefix master <my_branch> > DRILL-1234.1.patch.txt (correct
command)
> 4. git diff master <my_branch> > DRILL-1234.1.patch.txt (current but incompatible
command)



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message