drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Parth Chandra" <pchan...@maprtech.com>
Subject Re: Review Request 26455: DRILL -1511. C++ Client. Fix compiling issues in DRILL-1297 patch on clang
Date Wed, 22 Oct 2014 05:38:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26455/#review57751
-----------------------------------------------------------

Ship it!


Ship It!

- Parth Chandra


On Oct. 8, 2014, 8:39 p.m., Xiao Meng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26455/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 8:39 p.m.)
> 
> 
> Review request for drill and Parth Chandra.
> 
> 
> Bugs: DRILL-1511
>     https://issues.apache.org/jira/browse/DRILL-1511
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> - Remove forward enum type declaration (not allowed in C++ 03).
> - Add space between `<` and `::` to fix compilation of clang
> 
> 
> Diffs
> -----
> 
>   contrib/native/client/src/clientlib/drillClient.cpp db7d5a8 
>   contrib/native/client/src/include/drill/drillClient.hpp f1369ee 
> 
> Diff: https://reviews.apache.org/r/26455/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Xiao Meng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message