drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hanifi Gunes" <hanifigu...@gmail.com>
Subject Re: Review Request 33727: DRILL-2811: Fix connection to individual drill bit. Allow port to be optional.
Date Sat, 02 May 2015 01:29:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33727/#review82306
-----------------------------------------------------------

Ship it!


Ship It!

- Hanifi Gunes


On April 30, 2015, 6:29 p.m., Parth Chandra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33727/
> -----------------------------------------------------------
> 
> (Updated April 30, 2015, 6:29 p.m.)
> 
> 
> Review request for drill, Daniel Barclay, Hanifi Gunes, and Mehant Baid.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-2811: Fix connection to individual drill bit. (The isDirect method was checking
the wrong specifier). 
> Allow port to be optional. 
> Change to not load config twice.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ae0f580704c87add2d988896e76c51c5c7d7b22a

>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionConfig.java e353c71e923d06dd9925e6d12fabcd696c900f07

>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 7c690d8e343a2540b8adcd6654801600b2284072

> 
> Diff: https://reviews.apache.org/r/33727/diff/
> 
> 
> Testing
> -------
> 
> Tested with multiple drillbits - 
> Invalid port
> !connect "jdbc:drill:schema=test;drillbit=10.10.10.121:3000"
> No port specified
> !connect "jdbc:drill:schema=test;drillbit=10.10.10.121"
> Correct port specified
> !connect "jdbc:drill:schema=test;drillbit=10.10.10.121:31010"
> Different drillbit
> !connect "jdbc:drill:schema=test;drillbit=10.10.10.123:31010"
> No schem specified
> !connect "jdbc:drill:drillbit=10.10.10.123:31010"
> 
> 
> Thanks,
> 
> Parth Chandra
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message