drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mehant Baid" <baid.meh...@gmail.com>
Subject Re: Review Request 34499: DRILL-3032: repeated vectors should handle late type && instantiate its children upon construction
Date Thu, 21 May 2015 22:42:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34499/#review84807
-----------------------------------------------------------


Can you add a unit test like the one mentioned in the JIRA report for this bug.


exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseRepeatedValueVector.java
<https://reviews.apache.org/r/34499/#comment136192>

    In which case where we creating vector with Late type. Shouldn't we have materialized
the field earlier?



exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedListVector.java
<https://reviews.apache.org/r/34499/#comment136195>

    store children's size in a local variable instead of making multiple calls.


- Mehant Baid


On May 20, 2015, 9:39 p.m., Hanifi Gunes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34499/
> -----------------------------------------------------------
> 
> (Updated May 20, 2015, 9:39 p.m.)
> 
> 
> Review request for drill and Mehant Baid.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-3032: repeated vectors should handle late type && instantiate its children
upon construction
> 
> MaterializedField.java
> - remove unused imports
> 
> BaseRepeatedValueVector.java
> - repeated types should not attempt to create a child vector of late type
> 
> RepeatedListVector.java
> - pass entire field rather than type to recursively instantiate a list vector
> 
> The rest
> - minor code refactoring
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/record/MaterializedField.java 64ba8611b36377084d3912f997ea428715ed2cf8

>   exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java e5f4be1e960462f27f5c9477a3225fb7767cfde0

>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseRepeatedValueVector.java
bcf0793751443ffed5879d36e09dc97ac4f2591f 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/VectorDescriptor.java 9a29848cf88bcba9e8d9ef57eec08f28a0ba9b4f

>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedListVector.java
b5de8b1e2081e13c36fe563002dad00341367b6e 
> 
> Diff: https://reviews.apache.org/r/34499/diff/
> 
> 
> Testing
> -------
> 
> all
> 
> 
> Thanks,
> 
> Hanifi Gunes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message