drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hanifi Gunes" <hanifigu...@gmail.com>
Subject Re: Review Request 34498: DRILL-3143: MaterializedField#clone should deep copy itself without disregarding its children
Date Fri, 22 May 2015 22:21:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34498/
-----------------------------------------------------------

(Updated May 22, 2015, 10:21 p.m.)


Review request for drill, Jason Altekruse and Steven Phillips.


Repository: drill-git


Description
-------

DRILL-3143: MaterializedField#clone should deep copy itself without disregarding its children

MaterializedField
- deep copy on clone
- made children an order sensitive set type
- mark variables final
- use trivial method names
 
TestMaterializedField
- various test cases around clone functionality

All others
- updated method invocations on MaterializedField


Diffs (updated)
-----

  exec/java-exec/src/main/codegen/templates/FixedValueVectors.java 0dffa0ba3f1eaa5247ab7feb9f01a7388a7bf1ce

  exec/java-exec/src/main/codegen/templates/NullableValueVectors.java ce6a3a7301e85248017fc90539ad4239a688a856

  exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java 37b8fac12012d11eeaa50c04e8062ef2430e122b

  exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java 529f21b36f6f8687b255935ff0982ef459578945

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
5fd866f17fe23b1d3e93355b43562312b81ad5c6 
  exec/java-exec/src/main/java/org/apache/drill/exec/record/MaterializedField.java 64ba8611b36377084d3912f997ea428715ed2cf8

  exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseValueVector.java 67c489daf0a172d4fe0f8df1abb07a0454091299

  exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java f88a7bcd2049297590c58eadb4da963035f03c83

  exec/java-exec/src/test/java/org/apache/drill/exec/record/TestMaterializedField.java PRE-CREATION


Diff: https://reviews.apache.org/r/34498/diff/


Testing
-------

all


Thanks,

Hanifi Gunes


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message