drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Westin" <chriswesti...@gmail.com>
Subject Re: Review Request 34598: DRILL-2923: Ensure all unit tests pass without assertions enabled
Date Tue, 26 May 2015 17:40:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34598/
-----------------------------------------------------------

(Updated May 26, 2015, 10:39 a.m.)


Review request for drill and Jason Altekruse.


Changes
-------

Added testing information, and added Jason as a reviewer.


Bugs: DRILL-2923
    https://issues.apache.org/jira/browse/DRILL-2923


Repository: drill-git


Description (updated)
-------

Modified a number of unit tests not to use java assert, but to instead use one of junit's
assertTrue(), assertFalse(), or some other form. Modified test support code that used asserts
to throw IllegalStateExceptions instead.


Diffs
-----

  common/src/test/java/org/apache/drill/common/expression/PathSegmentTests.java 07b2385 
  contrib/storage-hive/core/src/test/java/org/apache/drill/exec/TestHivePartitionPruning.java
7353e05 
  exec/java-exec/src/test/java/org/apache/drill/PlanTestBase.java f909681 
  exec/java-exec/src/test/java/org/apache/drill/exec/compile/bytecode/ReplaceMethodInvoke.java
bc2d929 
  exec/java-exec/src/test/java/org/apache/drill/exec/fn/interp/ExpressionInterpreterTest.java
2a83a53 
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/mergereceiver/TestMergingReceiver.java
0122c08 
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/sort/TestSimpleSort.java
f37624a 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/ischema/TestInfoSchemaFilterPushDown.java
b6e789b 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/FieldInfo.java 34f60ba

  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetRecordReaderTest.java
8fdaa72 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetResultListener.java
6326478 
  exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/fn/TestJsonReaderWithSparseFiles.java
d674d47 
  exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestRepeated.java
6e2a2b5 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataGetColumnsTest.java a6c2da8

  exec/jdbc/src/test/java/org/apache/drill/jdbc/ResultSetGetMethodConversionsTest.java 4ad80d1

  exec/jdbc/src/test/java/org/apache/drill/jdbc/proxy/TracingProxyDriverTest.java 389cbac

  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2128GetColumnsDataTypeNotTypeCodeIntBugsTest.java
4203c4a 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2461IntervalsBreakInfoSchemaBugTest.java
f0a9eb0 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2463GetNullsFailedWithAssertionsBugTest.java
c355142 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java 4081696 

Diff: https://reviews.apache.org/r/34598/diff/


Testing (updated)
-------

mvn install, both with and without assertions enabled (via the root pom.xml's surefire args)
presubmit suite
* Regression and Customer fails with the known execHive.sh issues
* TPCH SF100 passes


Thanks,

Chris Westin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message