drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hanifi Gunes <hgu...@maprtech.com>
Subject Re: RecordBatchLoader.load(...) SchemaChangeException
Date Mon, 04 May 2015 18:59:55 GMT
We now use return value as an indicator of schema change. As Steven says,
throws statement should be removed.

On Mon, May 4, 2015 at 11:54 AM, Steven Phillips <sphillips@maprtech.com>
wrote:

> I think it is most likely a remnant that should be removed.
>
> On Mon, May 4, 2015 at 11:38 AM, Daniel Barclay <dbarclay@maprtech.com>
> wrote:
>
> > In RecordBatchLoader, the load(...) method is declared to throw
> > SchemaChangeException, but it never actually throws
> SchemaChangeException.
> >
> > It supposed to be declared to throw SchemaChangeException?  (E.g., are we
> > reserving the "right" for load(...) to throw that, and declaring "throws
> > SchemaChangeException" to help make sure callers already handle it in
> case
> > load(...) later changes to actually throw it sometimes?)
> >
> > Or is that "throws" a remnant that should be removed sometime?
> >
> >
> > Daniel
> > --
> > Daniel Barclay
> > MapR Technologies
> >
>
>
>
> --
>  Steven Phillips
>  Software Engineer
>
>  mapr.com
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message