drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdelhakim deneche" <adene...@gmail.com>
Subject Re: Review Request 34603: DRILL-3167: When a query fails, Foreman should wait for all fragments to finish cleaning up before sending a FAILED state to the client
Date Tue, 30 Jun 2015 21:32:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34603/
-----------------------------------------------------------

(Updated June 30, 2015, 9:32 p.m.)


Review request for drill, Jacques Nadeau, Jason Altekruse, and Sudheesh Katkam.


Changes
-------

updated patch addresses review comments. I also updated ControlMessageHandler.cancelFragment()
to return OK if the fragment has recently finished

Note: some of the changes I made in this patch are not shown properly if you do a partial
diff 3-4, I would suggest to look at the full set of changes instead. Thx


Bugs: DRILL-3167
    https://issues.apache.org/jira/browse/DRILL-3167


Repository: drill-git


Description
-------

- In case of a failure the Foreman will cancel all fragments and move to a FAILING state until
all fragments are terminated
- QueryManager.cancelExecutingFragments() returns false if no fragment available
- Web UI still displays FAILED when Foreman state is FAILING


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/WorkEventBus.java 3e461ef

  exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
6656bf6 
  exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java
dd26a76 
  exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlMessageHandler.java
9f302a2 
  exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 716fb66 
  exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java 9318233

  exec/java-exec/src/main/resources/rest/profile/list.ftl cf92ede 
  exec/java-exec/src/main/resources/rest/profile/profile.ftl 46cdc83 
  protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java e76d748 
  protocol/src/main/java/org/apache/drill/exec/proto/beans/QueryResult.java 474e330 
  protocol/src/main/protobuf/UserBitShared.proto 0451fd2 

Diff: https://reviews.apache.org/r/34603/diff/


Testing
-------

unit tests are passing


Thanks,

abdelhakim deneche


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message