drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-1065: Support for ALTER ... RESET statem...
Date Thu, 01 Oct 2015 02:23:54 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java
    @@ -179,6 +181,7 @@ public void validate(final OptionValue v) {
         public TypeValidator(final String name, final Kind kind, final OptionValue defValue)
    +      checkArgument(defValue.type == OptionType.SYSTEM, "Default value must be SYSTEM
    --- End diff --
    I am confused.. what does "these" refer to? I do not see any other precondition checks.
    That change was addressing Hakim's comment [here](https://github.com/apache/drill/pull/159/files#diff-767c81796fcc968c436bd67655218f1aR83).
The issue was when ControlsOptionValidator was being registered with the SystemOptionManager,
the default option was being stored within SystemOptionManager as a SESSION option.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message