drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3623: Use shorter query path for LIMIT 0...
Date Thu, 29 Oct 2015 01:08:14 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/193#discussion_r43339305
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/FindLimit0Visitor.java
---
    @@ -46,6 +51,32 @@ public static boolean containsLimit0(RelNode rel) {
         return visitor.isContains();
       }
     
    +  public static DrillRel addLimitOnTopOfLeafNodes(final DrillRel rel) {
    +    final RelShuttleImpl shuttle = new RelShuttleImpl() {
    +
    +      private RelNode addLimitAsParent(RelNode node) {
    +        final RexBuilder builder = node.getCluster().getRexBuilder();
    +        final RexLiteral offset = builder.makeExactLiteral(BigDecimal.ZERO);
    +        final RexLiteral fetch = builder.makeExactLiteral(BigDecimal.ZERO);
    +        return new DrillLimitRel(node.getCluster(), node.getTraitSet(), node, offset,
fetch);
    --- End diff --
    
    Thank you Julian, RelBuilder seems perfect for this case.
    
    Jinfeng, for now, making this visitor more general and using RelBuilder needs bigger changes,
so I am adding a TODO(DRILL-3993).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message