drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3232: Handle promoting writers and vecto...
Date Fri, 30 Oct 2015 04:22:20 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/207#discussion_r43470768
  
    --- Diff: common/src/main/java/org/apache/drill/common/types/Types.java ---
    @@ -34,6 +34,13 @@
       public static final MajorType REQUIRED_BIT = required(MinorType.BIT);
       public static final MajorType OPTIONAL_BIT = optional(MinorType.BIT);
     
    +  public static boolean isUnion(MajorType toType) {
    +    if (toType.getMinorType() == MinorType.UNION) {
    --- End diff --
    
    probably better as 
    
    return toType.getMinorType() == MinorType.UNION;


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message