drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3232: Handle promoting writers and vecto...
Date Fri, 30 Oct 2015 04:28:52 GMT
Github user jacques-n commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/codegen/templates/EventBasedRecordWriter.java ---
    @@ -118,6 +119,9 @@ public void endField() throws IOException {
       public static FieldConverter getConverter(RecordWriter recordWriter, int fieldId, String
fieldName, FieldReader reader) {
    +    if (reader instanceof UnionReader) {
    --- End diff --
    why isn't this part of the case statement below (instead of instanceof)?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message