drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3232: Handle promoting writers and vecto...
Date Fri, 30 Oct 2015 04:30:18 GMT
Github user jacques-n commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/codegen/templates/MapWriters.java ---
    @@ -52,9 +52,18 @@
       private final Map<String, FieldWriter> fields = Maps.newHashMap();
       <#if mode == "Repeated">private int currentChildIndex = 0;</#if>
    -  public ${mode}MapWriter(${containerClass} container, FieldWriter parent) {
    +  private final boolean unionEnabled;
    +  private final boolean unionInternalMap;
    --- End diff --
    Can you give a description of the unionInternalMap parameter and why that is needed in
a javadoc?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message