drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3232: Handle promoting writers and vecto...
Date Fri, 30 Oct 2015 04:32:08 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/207#discussion_r43471089
  
    --- Diff: exec/java-exec/src/main/codegen/templates/NullReader.java ---
    @@ -56,11 +56,17 @@ public void copyAsValue(MapWriter writer) {}
     
       public void copyAsValue(ListWriter writer) {}
     
    -  <#list vv.types as type><#list type.minor as minor><#assign name = minor.class?cap_first
/> 
    +  public void copyAsValue(UnionWriter writer) {}
    +
    +  <#list vv.types as type><#list type.minor as minor><#assign name = minor.class?cap_first
/>
    +  public void read(${name}Holder holder){
    +    throw new UnsupportedOperationException("NullReader cannot read into non-nullable
holder");
    --- End diff --
    
    UserException? I'm not sure what this message even means or what would cause this. I'm
thinking it is a dev only message and thus Unsupported would be fine but want to confirm.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message