drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3232: Handle promoting writers and vecto...
Date Fri, 30 Oct 2015 05:13:50 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/207#discussion_r43472371
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
---
    @@ -288,7 +288,7 @@ protected boolean setupNewSchema() throws SchemaChangeException {
         final IntOpenHashSet transferFieldIds = new IntOpenHashSet();
     
         final NamedExpression flattenExpr = new NamedExpression(popConfig.getColumn(), new
FieldReference(popConfig.getColumn()));
    -    final ValueVectorReadExpression vectorRead = (ValueVectorReadExpression)ExpressionTreeMaterializer.materialize(flattenExpr.getExpr(),
incoming, collector, context.getFunctionRegistry(), true);
    +    final ValueVectorReadExpression vectorRead = (ValueVectorReadExpression)ExpressionTreeMaterializer.materialize(flattenExpr.getExpr(),
incoming, collector, context.getFunctionRegistry(), true, false);
    --- End diff --
    
    Can you just update materialize to have a version that doesn't take unionTypeEnabled and
then uses false as the input. That way we don't need to change all the expressions (and then
change them back once union type is always enabled).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message